Differentiate between source root categories.

Review Request #4230 — Created Sept. 13, 2016 and submitted

benjyw
pants
2483
pants-reviews
jsirois

Source roots now know whether they are "source", "test" or
"thirdparty".

This allows us to get rid of the "go_remote" hack in go_buildgen.py.

In the future this may end up being useful for other things.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/159487089

  1. 
      
  2. src/python/pants/source/source_root.py (Diff revision 2)
     
     

    It wasn't marked :API: public so it seems to me its fine to kill this default to help sniff out folks who are depending on the non-public API. Looks like just test_source_root_trie uses this form right now and it could just as well use a helper.

    1. Oh yeah, that wasn't out of concern for the API, it was me making my life easier by not having to change the test too much. But yeah, might as well use a helper. Will make that change.

  3. 
      
  1. Ship It!
  2. 
      
Review request changed

Status: Closed (submitted)

Change Summary:

bb9667f138228bcf0bc89f4811b928f6fc2de14d

  1. Ship It!
  2. 
      
Loading...