Restore ChangedTargetGoalsIntegrationTest.

Review Request #4227 - Created Sept. 12, 2016 and submitted

Information
John Sirois
pants
jsirois/test-changed-test/reenable/part2
3859
19e3940...
Reviewers
pants-reviews
benjyw, mateor, peiyu, stuhood
All of its tests were marked xfail but are now re-enabled with changes
to ensure the targets and git repo under test are isolated from the
host pants repo.

In order to facilitate integration tests using an ephemeral git repo,
a change is made to `build-support/pants_venv` to not rely on git to
find the host pants repo root directory.

 build-support/common.sh                                          |   4 +-
 build-support/pants_venv                                         |   2 +-
 tests/python/pants_test/tasks/BUILD                              |   3 +
 tests/python/pants_test/tasks/test_changed_target_integration.py | 149 ++++++++++++++++++++++++++++++++++++--------------
 tests/python/pants_test/testutils/BUILD                          |   1 +
 tests/python/pants_test/testutils/git_util.py                    |  29 +++++++---
 6 files changed, 135 insertions(+), 53 deletions(-)

Locally green: ./pants test-changed.

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/159416022

John Sirois
John Sirois
John Sirois
John Sirois
Mateo Rodriguez
John Sirois
Review request changed

Status: Closed (submitted)

Change Summary:

Now on master:

git log -1 origin/master
commit 2f520bab6e7dad26281c6875d88d638b0904ea85
Author: John Sirois <john.sirois@gmail.com>
Date:   Tue Sep 13 12:10:56 2016 -0600

    Restore ChangedTargetGoalsIntegrationTest.
    
    All of its tests were marked xfail but are now re-enabled with changes
    to ensure the targets and git repo under test are isolated from the
    host pants repo.
    
    In order to facilitate integration tests using an ephemeral git repo,
    a change is made to `build-support/pants_venv` to not rely on git to
    find the host pants repo root directory.
    
    Testing Done:
    Locally green: `./pants test-changed`.
    
    CI went green here:
      https://travis-ci.org/pantsbuild/pants/builds/159416022
    
    Bugs closed: 3859
    
    Reviewed at https://rbcommons.com/s/twitter/r/4227/
Loading...