Edit Greeting{,Test}.java to get a known edit sha for tests.

Review Request #4217 — Created Sept. 9, 2016 and submitted

jsirois
pants
jsirois/test-changed-test/reenable/part1
3851
a723c84...
pants-reviews
benjyw, stuhood, zundel
This will be used to re-enable tests in
`tests/python/pants_test/tasks/test_changed_target_integration.py`.

 examples/src/java/org/pantsbuild/example/hello/greet/Greeting.java       | 2 +-
 examples/tests/java/org/pantsbuild/example/hello/greet/GreetingTest.java | 9 +++++----
 2 files changed, 6 insertions(+), 5 deletions(-)

Locally green:

./pants test examples/tests/java/org/pantsbuild/example/hello/greet

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/158877403

  1. NB: This will be used in conjunction with https://docs.travis-ci.com/user/customizing-the-build#Git-Clone-Depth as a medium-term fix before I dive into re-working the test set up its own ephemeral git repo.
  2. 
      
  1. Ship It!
  2. 
      
  1. Worth mentioning in each of these files that editting them will necessitate updating the test?

    1. It won't, I'll be changing the test to use a (single) revision range.
    2. That's not true, I don't think. The SHA will have to be updated only after a certain number of commits land after it in the log. But it sounds like John is going to set it up to have an ephemeral git setup instead of relying on the example code git history.

    3. It turned out to be easier to just skip to the real solution anyhow: https://rbcommons.com/s/twitter/r/4227/
  2. 
      
  1. Ship It!
  2. 
      
Review request changed

Status: Closed (submitted)

Change Summary:

Now on master:

git log -1 origin/master
commit 7b210b5445654f690267fe71542a5a64f0bf9870
Author: John Sirois <john.sirois@gmail.com>
Date:   Sun Sep 11 10:26:27 2016 -0600

    Edit Greeting{,Test}.java to get a known edit sha for tests.
    
    This will be used to re-enable tests in
    `tests/python/pants_test/tasks/test_changed_target_integration.py`.
    
    Testing Done:
    Locally green:
    ```
    ./pants test examples/tests/java/org/pantsbuild/example/hello/greet
    ```
    
    CI went green here:
      https://travis-ci.org/pantsbuild/pants/builds/158877403
    
    Bugs closed: 3851
    
    Reviewed at https://rbcommons.com/s/twitter/r/4217/
Loading...