Re-enable test_junit_tests_using_cucumber.

Review Request #4212 — Created Sept. 9, 2016 and submitted

jsirois
pants
jsirois/xfail/eliminate
3848
0f517cb...
pants-reviews
gmalmquist, zundel
The required update to the junit runner was upgraded to long ago.

 testprojects/3rdparty/cucumber/BUILD                                    | 8 +++++++-
 testprojects/tests/java/org/pantsbuild/testproject/cucumber/BUILD       | 6 +++---
 tests/python/pants_test/backend/jvm/tasks/test_junit_run_integration.py | 3 +--
 3 files changed, 11 insertions(+), 6 deletions(-)

Locally green with no skips or xfails:

./pants test tests/python/pants_test/backend/jvm/tasks:junit_run_integration -- -v

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/159135750

JS
ST
  1. Thanks John!

  2. testprojects/3rdparty/cucumber/BUILD (Diff revision 1)
     
     

    It seems unlikely that all consumers will want this at scope runtime, so this may be a good case for cuke-guice to use the scoped(':com.google.inject.guice', scope='runtime') macro. But no real preference.

    1. Thanks!  Even though the only consumer is this one unit test I both learned something new (scoped) and it sets the right example.
  3. 
      
JS
JS
JS
Review request changed

Status: Closed (submitted)

Change Summary:

Now on master:

git log -1 origin/master
commit 4299f83f1c27d710167d4aa764a704dcc6ae36e4
Author: John Sirois <john.sirois@gmail.com>
Date:   Sun Sep 11 12:03:23 2016 -0600

    Re-enable test_junit_tests_using_cucumber.
    
    The required update to the junit runner was upgraded to long ago.
    
    Testing Done:
    Locally green with no skips or xfails:
    ```
    ./pants test tests/python/pants_test/backend/jvm/tasks:junit_run_integration -- -v
    ```
    
    CI went green here:
      https://travis-ci.org/pantsbuild/pants/builds/159135750
    
    Bugs closed: 3848
    
    Reviewed at https://rbcommons.com/s/twitter/r/4212/
Loading...