[engine] Daemon cacheable `changed`.

Review Request #4207 - Created Sept. 6, 2016 and submitted

Information
Kris Wilson
pants
kwlzn/engine/cached_changed
3773, 3816
Reviewers
pants-reviews
jsirois, nhoward_tw, patricklaw, peiyu, stuhood, yujiec
  • Implement AscendantAddresses for upwards path target traversal supporting changed.
  • Implement a new Changed subsystem for global parameters and functionality across all tasks.
  • Add inline, dual-pathed 'alternate target roots' mechanism for applying --changed functionality to any goal to rewrite its target roots in the v2 path (e.g. ./pants --enable-v2-engine --changed-parent=master list, ./pants --enable-v2-engine --changed-parent=master test). Intentionally avoid removal of alternate_target_roots at the Task level as Foursquare et al currently rely on this.
  • Kill ChangedFileTaskMixin in favor of the above.
  • Implement EngineCmdLineSpecParser, EngineSourceMapper, EngineChangeCalculator and friends for pre-BuildGraph target inspection and traversal.
  • Integration test coverage for v1.changed == v2.changed == v2.list.
  • Implement a new Engine.product_request() method for simplified, inline engine product requests.
  • Make BuildFile._is_buildfile_name public.
  • Eliminate checking of DeprecationWarning warnings in the pantsd integration test.
  • Add a new PantsRunIntegrationTest.add_test() class method for simplified test testcase generation.

This currently leaves the ./pants --enable-v2-engine list breakage as a TODO'd followup due to review size, which masks further test coverage for things like target aliases etc. Planning to attack that as a follow-on.

https://travis-ci.org/pantsbuild/pants/builds/161798482

Issues

  • 0
  • 13
  • 3
  • 16
Description From Last Updated
Peiyu Wang
Nick Howard (Twitter)
Stu Hood
Kris Wilson
John Sirois
Yujie Chen
Nick Howard (Twitter)
John Sirois
John Sirois
Kris Wilson
Nick Howard (Twitter)
Kris Wilson
Nick Howard (Twitter)
Yujie Chen
Kris Wilson
Stu Hood
Kris Wilson
Kris Wilson
Review request changed

Status: Closed (submitted)

Change Summary:

thanks Peiyu, Nick, John, Yujie & Stu! this is in master @ https://github.com/pantsbuild/pants/commit/68e68ba5b5d772c6dfbd0586363da3946eec8c59

Loading...