[jvm-compile][test] Add test explicitly checking classpath for z.jars

Review Request #4199 - Created Aug. 30, 2016 and submitted

Information
Nick Howard (Twitter)
pants
3825
Reviewers
pants-reviews
gmalmquist, stuhood

This patch adds a test to the zinc compile tests to explicitly check that --use-classpath-jars adds z.jars to the compile classpath.

While working on https://rbcommons.com/s/twitter/r/4198, I thought I saw that --use-classpath-jars wasn't being respected for modifying the compile classpath. I was wrong. I wrote a test to check, and it passed.

While investigating, I noticed that there weren't any tests that explicitly checked for the z.jars on the classpath. I then broke the flag by commenting out the part that swaps out the class directory and reran all the jvm compile tests. The test in this patch was the only one that failed.

Ran jvm compile tests locally. CI away on the linked PR.

Yi Cheng
Garrett Malmquist
Nick Howard (Twitter)
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as https://github.com/pantsbuild/pants/commit/70cc99458ba78ce92e90b8a052e7d6e4c5767ebd
Loading...