Plumb fetch timeout through `BinaryUtil`.

Review Request #4196 - Created Aug. 29, 2016 and submitted

Information
John Sirois
pants
jsirois/issues/3817
3817, 3822
6a7e65f...
Reviewers
pants-reviews
gmalmquist, kwlzn, zundel
Previously, the option was stored by `BinaryUtil` but not forwarded to
the underlying `Fetcher` it used.

 src/python/pants/binaries/binary_util.py             |  5 ++++-
 tests/python/pants_test/binaries/BUILD               |  2 ++
 tests/python/pants_test/binaries/test_binary_util.py | 21 +++++++++++++++++----
 3 files changed, 23 insertions(+), 5 deletions(-)

Added failing test that this patch fixes:
./pants test tests/python/pants_test/binaries:binary_util

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/156068156

John Sirois
Kris Wilson
John Sirois
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Change Summary:

Now on master:

git log -1 origin/master
commit c9679b0a238b3c3ef26c8cb8008810c924dcc0da
Author: John Sirois <john.sirois@gmail.com>
Date:   Mon Aug 29 16:55:31 2016 -0600

    Plumb fetch timeout through `BinaryUtil`.
    
    Previously, the option was stored by `BinaryUtil` but not forwarded to
    the underlying `Fetcher` it used.
    
    Testing Done:
    Added failing test that this patch fixes:
      `./pants test tests/python/pants_test/binaries:binary_util`
    
    CI went green here:
      https://travis-ci.org/pantsbuild/pants/builds/156068156
    
    Bugs closed: 3817, 3822
    
    Reviewed at https://rbcommons.com/s/twitter/r/4196/
Loading...