A clear error message for checkstyle misconfiguration.

Review Request #4176 — Created Aug. 19, 2016 and submitted

benjyw
pants
pants-reviews
stuhood
Previously if the --configuration option wasn't specified,
you'd get an opaque error much further down, in a call to maybe_list.

Also:

- Updates to a modern version of checkstyle by default.  6.1.1 doesn't
  support various checks, so standard configs (such as sun's or google's)
  that you download from checkstyle's site don't work with it.
  It's better to impose on the very few (if any) repos using java6 than
  on everyone else.

- Fix a text nit in an unrelated readme.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/153440606

  1. 
      
  2. Is it possible to reflectively get the option name here?

    1. Nothing that comes to mind immediately. I don't think we do this typically?

  3. 
      
Review request changed

Status: Closed (submitted)

Change Summary:

5b2a7dfeb0580ec3c1119bb7601ff817c3a6f8a7

Loading...