Support exclude_target_regexps and ignore_patterns in v2 engine

Review Request #4172 - Created Aug. 19, 2016 and submitted

Information
Yujie Chen
pants
3671, 3780, 3801
Reviewers
pants-reviews
kwlzn, mateor, patricklaw, stuhood

This change does the followings:
1. Add support for exclude_target_regexps and ignore_patterns options in v2 engine.
2. Deprecate --ignore-patterns in version 1.3.0, replace with --build-ignore. If both are given, pants will explode.
3. Mark tests that failed without 1 in v2 engine with "ensure_engine" decorator.
4. Move test_ignore_patterns_pants_ini_integration.py from tests/python/pants_test/base to tests/python/pants_test/engine/legacy and rename to test_build_ignore_integration.py
5. Add test cases for 1.

Note:
for tests/python/pants_test/projects/test_testprojects_integration.py, I split the original tests into 2 tests, one using v1 engine, the other using v2 engine. The reason I don't use @ensure_engine here is that, in travis-ci, it takes more than 10 minutes for that test to finish and travis-ci will error out if there is no output for more than 10 minutes. The alternative is to use travis_wait, but that causes another failure in ci, which I have no idea why it happens, and I have opened an issue in travis github. So for now, spliting the test is the best solution we have.

ci green:
https://travis-ci.org/pantsbuild/pants/builds/155427534

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Yujie Chen
Kris Wilson
Yujie Chen
Yujie Chen
Yujie Chen
Kris Wilson
Yujie Chen
Yujie Chen
Stu Hood
Yi Cheng
Yujie Chen
Yujie Chen
Mateo Rodriguez
Yujie Chen
Yujie Chen
Review request changed

Status: Closed (submitted)

Change Summary:

63ea982f2bb397e407c8f8ebd75876eedf5ed79e Thanks Kris, Stu, Yi and Mateo!

Loading...