Refactor classpath consolidation into a separate task.

Review Request #4152 - Created Aug. 12, 2016 and submitted

Information
Matt Olsen
pants
3778
Reviewers
pants-reviews
jsirois, mateor, nhoward_tw, patricklaw, stuhood, zundel

Previously there were two invalidation blocks inside of bundle_create.
In some cases where the classpath was changed by another task this caused
a vt to be validated before bundle happened and bundle was then skipped.

  • Move consolidate_classpath to a separate task.
  • Update bundle_create to rely on the consolidated classpath.

CI green: https://travis-ci.org/pantsbuild/pants/builds/154516443
personal fork is green

Tested in twitter monorepo and the case that previously crashes now works correctly.

Issues

  • 0
  • 6
  • 0
  • 6
Description From Last Updated
Nick Howard (Twitter)
Yujie Chen
Stu Hood
Matt Olsen
Yujie Chen
Matt Olsen
Yujie Chen
Matt Olsen
Matt Olsen
Nick Howard (Twitter)
Mateo Rodriguez
Matt Olsen
Mateo Rodriguez
Matt Olsen
Review request changed

Status: Closed (submitted)

Change Summary:

commit f27e77b315e8741d763583f71cdc74504cc028ed

Loading...