-
-
src/python/pants/engine/graph.py (Diff revision 1) I think this will cause the BUILD file to be parsed a second time because the address mapper doesn't use the engine's cache.
Had you considered splitting the task that parses into address families?
With that, I think we could have a task that converts a single address into a BuildFileAddress by selecting the associated AddressMap and pulling the build file off of it.
Alternatively we could not erase the BUILD file path when constructing
AddressFamily
s, which would also make constructingBuildFileAddress
es easier. https://github.com/pantsbuild/pants/blob/master/src/python/pants/engine/mapper.py#L122-L125
[engine] Fix filedeps goal in v2 engine
Review Request #4137 — Created Aug. 5, 2016 and updated
Information | |
---|---|
ity | |
pants | |
3752, 3753 | |
Reviewers | |
pants-reviews | |
jsirois, kwlzn, nhoward_tw, stuhood |
-
In the v1 engine an Address is resolved to a BuildFileAddress, in the v2 engine thats not the case. Hence, invocation of goals such as filedeps causes an exception.
-
Use
address_mapper
to correctly resolve anAddress
to aBuildFileAddress
$ ./build-support/bin/ci.sh succeeded locally
travis ci running - https://travis-ci.org/pantsbuild/pants/builds/149976208
NH