Fix BundleAdaptor to BundleProps Conversion

Review Request #4129 - Created July 29, 2016 and submitted

Information
Yujie Chen
pants
3739
Reviewers
pants-reviews
kwlzn, stuhood

This review https://rbcommons.com/s/twitter/r/4057/, implements conversion from BundleAdaptor to BundleProps. However I found an issue in my recent testing in Twitter's internal repo. "bundle" declaration in BUILD takes 4 arguments, "rel_path", "relative_to", "mapper" and "fileset". They were all captrued and stored in BundleAdaptor objects. But the current conversion logic will pass only fileset to newly created BundleProps object and ignore others. This review fixes this issue.

ci green:
https://travis-ci.org/pantsbuild/pants/builds/150737269

Issues

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Yi Cheng
Stu Hood
Yujie Chen
Kris Wilson
Yujie Chen
Kris Wilson
Yujie Chen
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks, Yi, Stu and Kris!

Loading...