Ensure target `resources=` ordering is respected in the v2 engine.

Review Request #4128 — Created July 29, 2016 and submitted

kwlzn
pants
3736
pants-reviews
jsirois, nhoward_tw, patricklaw, stuhood
  • Repair an ordering issue with treatment of the resources= kwarg in the v2 engine that lead to an internal test failure due to a malformed classpath.
  • Introduce a new dual_path_engine_test decorator for dual-path execution of v1 vs v2 engine integration tests.
  • Add an integration test that utilizes the new decorator.

https://travis-ci.org/pantsbuild/pants/builds/148177028

ST
  1. Thanks Kris!

  2. Should edit the other target definition to refer to this one as well probably.

  3. Maybe just engine_test?

    1. was trying to highlight the "this will run 2x" catch here with the explicit "dual path" in name, but I agree it's awkward.

      went with ensure_engine to match the existing ensure_cache.

  4. 
      
KW
KW
YU
  1. Ship It!
  2. 
      
KW
Review request changed

Status: Closed (submitted)

Change Summary:

thanks Stu & Yujie! this is in @ 0d8602269c40f6d0c7b63b999750ef2b82a88215

Loading...