Buffer the ConsoleRunner's use of stdio.

Review Request #4101 - Created July 19, 2016 and submitted

Information
John Sirois
pants
jsirois/issues/3684/buffer_stdio
3684, 3696
424e48e...
Reviewers
pants-reviews
kwlzn, stuhood, zundel
This results in drastic speed gains for tests that do alot of stdio.

 src/java/org/pantsbuild/tools/junit/impl/ConsoleRunnerImpl.java   | 6 ++++--
 tests/java/org/pantsbuild/tools/junit/impl/ConsoleRunnerTest.java | 3 ++-
 2 files changed, 6 insertions(+), 3 deletions(-)

Locally before:

$ ./pants test.junit tests/java/org/pantsbuild/tools/junit/impl/::
...
15:47:50 00:01     [junit]
15:47:50 00:01       [run]
                     OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
                     OpenJDK 64-Bit Server VM warning: ignoring option UseSplitVerifier; support was removed in 8.0
                     Auto-detected 8 processors, using -parallel-threads=8
                     ......................................................................................................................................................................................................................................................................................................................................................................FATAL: VM exiting uncleanly.

FAILURE: Timeout of 180 seconds reached

And after always green between 50 and 52 seconds.

CI went green here:
http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/job/PR-3696/1/

Chris Heisterkamp
Chris Heisterkamp
Kris Wilson
John Sirois
Review request changed

Status: Closed (submitted)

Change Summary:

Now on master:

git log -1 origin/master
commit ee72a903e57cfac8aea2a2ec6b5b010a1b9047d0
Author: John Sirois <john.sirois@gmail.com>
Date:   Tue Jul 19 20:24:13 2016 -0600

    Buffer the ConsoleRunner's use of stdio.
    
    This results in drastic speed gains for tests that do alot of stdio.
    
    Testing Done:
    Locally before:
    ```
    $ ./pants test.junit tests/java/org/pantsbuild/tools/junit/impl/::
    ...
    15:47:50 00:01     [junit]
    15:47:50 00:01       [run]
                         OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
                         OpenJDK 64-Bit Server VM warning: ignoring option UseSplitVerifier; support was removed in 8.0
                         Auto-detected 8 processors, using -parallel-threads=8
                         ......................................................................................................................................................................................................................................................................................................................................................................FATAL: VM exiting uncleanly.
    
    FAILURE: Timeout of 180 seconds reached
    ```
    
    And after always green between 50 and 52 seconds.
    
    CI went green here:
      http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/job/PR-3696/1/
    
    Bugs closed: 3684, 3696
    
    Reviewed at https://rbcommons.com/s/twitter/r/4101/
Eric Ayers

   

Why do I feel we keep re-learning this lesson?

Loading...