Add support to Fetcher for `file:` URLs.

Review Request #4099 - Created July 19, 2016 and submitted

Information
John Sirois
pants
jsirois/issues/3324/fetcher/file_urls
3324, 3697
4142
53b9c17...
Reviewers
pants-reviews
stuhood
This also supports bare absolute path names.

 src/python/pants/net/http/fetcher.py             | 169 +++++++++++++++++++++++++++++++++++++++++---------
 tests/python/pants_test/net/http/test_fetcher.py |  53 +++++++++++++++-
 2 files changed, 192 insertions(+), 30 deletions(-)

Locally green: ./pants test tests/python/pants_test/net/http

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/146249850

John Sirois
John Sirois
John Sirois
John Sirois
Eric Ayers
Stu Hood
John Sirois
John Sirois
Eric Ayers
John Sirois
Review request changed

Status: Closed (submitted)

Change Summary:

Now on master:

git log -1 origin/master
commit 0450732d8144e122282c1cfd256c12ae3e7abc2a
Author: John Sirois <john.sirois@gmail.com>
Date:   Wed Jul 20 19:30:07 2016 -0600

    Add support to Fetcher for `file:` URLs.
    
    This also supports bare absolute path names.
    
    Testing Done:
    Locally green: `./pants test tests/python/pants_test/net/http`
    
    CI went green here:
      https://travis-ci.org/pantsbuild/pants/builds/146249850
    
    Bugs closed: 3324, 3697
    
    Reviewed at https://rbcommons.com/s/twitter/r/4099/
Stu Hood

Checking in with a success story: was just able to use this to test a new watchman binary using the following:

[binaries]
baseurls: +[
    'file:///Users/stuhood/watchman-binary',
  ]

[watchman]
version: 4.5.0-stuhood-1

Great timing. Thanks John!

Loading...