Don't filter directories in watchman subscription

Review Request #4095 - Created Aug. 13, 2016 and submitted

Information
Stu Hood
pants
3574, 3688
Reviewers
pants-reviews
kwlzn, patricklaw

As described on #3574, filtering changed directories meant that if a directory was deleted, we wouldn't get an event for the changed listing of its parent. It also wasn't really letting us avoid the underlying over-notification bug (linked in a comment here), because ignoring directories meant we needed to invalidate parent directories ourselves in FilesystemNode.

  • Drop type filter to include directory events.
  • Only invalidate the dirname of a file when it is contained in the root directory, since that is the only time when watchman will not send a directory event.
  • Fix test to not assume that a parent directory will be invalidated.

https://travis-ci.org/pantsbuild/pants/builds/155497553

Kris Wilson
Stu Hood
Stu Hood
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as d67cde7accf3c58e9eeb06f0be748d4c49da98fa

Loading...