ivy runner make a copy of jvm_options before mutating it

Review Request #4080 - Created July 14, 2016 and submitted

Information
Peiyu Wang
pants
3674
Reviewers
pants-reviews
nhoward_tw, patricklaw, stuhood, zundel

Noticed this while I turned debug level logging for publish.jar:

Executing: /.../java ... -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache -Divy.cache.dir=/Users/peiyu/.ivy2/limiter/cache ...
-cp ../../.ivy2/limiter/cache/org.apache.ivy/ivy/jars/ivy-2.5.0.alpha_20150115120000.jar:../../.ivy2/limiter/cache/fm.last.ivy.plugins/ivysvnresolver/jars/ivysvnresolver-2.2.0.jar:../../.ivy2/limiter/cache/org.tmatesoft.svnkit/svnkit/jars/svnkit-1.3.8.jar:../../.ivy2/limiter/cache/de.regnis.q.sequence/sequence-library/jars/sequence-library-1.0.2.jar:../../.ivy2/limiter/cache/net.java.dev.jna/jna/jars/jna-3.4.0.jar:../../.ivy2/limiter/cache/com.trilead/trilead-ssh2/jars/trilead-ssh2-1.0.0-build215.jar:../../.ivy2/limiter/cache/org.tmatesoft.sqljet/sqljet/jars/sqljet-1.1.2.jar:../../.ivy2/limiter/cache/org.antlr/antlr-runtime/jars/antlr-runtime-3.4.jar org.apache.ivy.Main -settings /Users/peiyu/workspace/source/.pants.d/publish/jar/ivysettings.xml -ivy /Users/peiyu/workspace/source/.pants.d/publish/jar/ivy.xml -deliverto /Users/peiyu/workspace/source/.pants.d/publish/jar/ivy.xml.unused -publish publish_local -publishpattern /Users/peiyu/workspace/source/.pants.d/publish/jar/[organisation]/[module]/[artifact]-[revision](-[classifier]).[ext] -revision 20160708055447-20ffb54 -m2compatible -verbose -overwrite args={'stderr': <pants.util.rwbuf.FileBackedRWBuf object at 0x11821af10>, 'stdout': <pants.util.rwbuf.FileBackedRWBuf object at 0x11821aed0>} at cwd=/Users/peiyu/workspace/source

https://travis-ci.org/peiyuwang/pants/builds/144634297
https://travis-ci.org/peiyuwang/pants/builds/144846662

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Nick Howard (Twitter)
Peiyu Wang
Eric Ayers
Nick Howard (Twitter)
Peiyu Wang
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as 2f836ad1bc33cfeabd5058919d3dd847a3bb6b8e

Loading...