Convert BundleAdaptor to BundleProps during JvmApp target creation

Review Request #4057 - Created July 8, 2016 and submitted

Information
Yujie Chen
pants
3641
Reviewers
pants-reviews
ity, kwlzn, stuhood

In v2 engine, TargetAdaptor serves as an intermediate state of a target and is eventually converted to its real target type, with one exception: BundleAdaptor.
BundleAdaptor never gets converted to its "traditional" counterpart (which is BundleProps).
BundleAdaptor structure and old BundleProps structure are not compatible, the hashing logic is based on BundleProps, thus exception will be thrown when applying the same logic onto BundleAdaptor

This review converts BundleAdaptor to BundleProps during the creation of JvmApp target.

ci green:
https://travis-ci.org/pantsbuild/pants/builds/144788292

Yujie Chen
Stu Hood
Yujie Chen
Kris Wilson
Yujie Chen
Kris Wilson
Yujie Chen
Stu Hood
Yujie Chen
Yujie Chen
Kris Wilson
Yujie Chen
Yujie Chen
Kris Wilson
Yujie Chen
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks Kris and Stu!

Loading...