Add `is_target_root` in export

Review Request #4030 — Created June 28, 2016 and submitted

wisechengyi
pants
3610
4032
pants-reviews
benjyw, nhoward_tw, peiyu, stuhood, zundel

To reconstruct the build graph for import/indexing optimization, intellij pants plugin would need to know where roots start in the graph.

https://travis-ci.org/pantsbuild/pants/builds/140961443

  • 0
  • 0
  • 2
  • 1
  • 3
Description From Last Updated
  1. 
      
  2. src/docs/export.md (Diff revision 1)
     
     

    thanks for updating

  3. Its likely that only very few elements will have this set. Maybe we should only conditionally add it to info?

    1. I would lean toward keeping it for every target, as some of developers' workflow is to import <some project>/::, in which case there would be many target roots.

  4. 
      
  1. 
      
  2. target_roots is often a list, so you might want to create a set out of it so that :: usage doesn't cause the linear search to take too long.

  3. 
      
  1. Thanks for the lookup set! I'd also like to see an explicit test. Other than that, LGTM!

  2. I'd like to see a test that explicitly exercises the false case for this.

  3. 
      
  1. Ship It!
  2. 
      
  1. Ship It!
  2. 
      
Review request changed

Status: Closed (submitted)

Change Summary:

ed5e22f4106eb8f0dbc83d16645d7b08ac2ede3e thanks gents!

Loading...