Set a default read timeout for fetching node pre-installed modules. 1 second default often fails

Review Request #4025 — Created June 26, 2016 and submitted

Eric Ayers
pants
3602, 3603
a5ebe31...
pants-reviews
benjyw, gmalmquist, kwlzn, stuhood

My internet connection is slow this morning and this download failed several times 20 minutes into ./build-support/bin/release.sh

I have heard complaints about this download failing in the past, this should fix it up, or provide a way for someone to lengthen the timeout further.

https://travis-ci.org/pantsbuild/pants/builds/140363519

Eric Ayers
  1. 
      
  2. Alternatively, maybe we should change the default timeout of 1.0 seconds inside of the Fetcher to 10 seconds.

    1. I would be down with that.

    2. I'm not going to be able to get to that this week so I went ahead and merged this as is so it won't impact this week's releaser.

  3. 
      
Kris Wilson
  1. Ship It!
  2. 
      
Benjy Weinberger
  1. Ship It!
  2. 
      
Eric Ayers
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks Kris, Stu, Benjy. Commit 22d9d82.

Loading...