A `remote_sources` target as a better mechanism for from_target.

Review Request #4014 - Created June 20, 2016 and submitted

Information
Garrett Malmquist
pants
gmalmquist/a-better-fix-for-deferred-sources
3592
Reviewers
pants-reviews
jsirois, stuhood, zundel

Stu suggested in https://rbcommons.com/s/twitter/r/3830/ that we
overhaul the deferred sources system to generate synthetic targets
instead. This should eliminate a lot of special casing we've been
having to do around deferred sources, since we can use the same
logic that was already handling synthetic targets created from
generated code.

This change adds the `remote_sources` target as a replacement for
the `from_target` object, and deprecates from_target.

In the meantime, I added an option to `deferred_sources_mapper`
to throw an exception if `from_target` is used, which will allow
individual users to eliminate their own usage of `from_target` in
favor of the more robust `remote_sources`.

Added unit test.

Jenkins went green here: http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/job/PR-3592/2/
CI went green here: https://travis-ci.org/pantsbuild/pants/builds/139023132
Jenkins went green here: http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/job/PR-3592/4/

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Garrett Malmquist
Eric Ayers
Garrett Malmquist
Eric Ayers
Stu Hood
Garrett Malmquist
Garrett Malmquist
Eric Ayers
Mateo Rodriguez
Garrett Malmquist
Review request changed

Status: Closed (submitted)

Change Summary:

In 25f5b99c9249f572a744ae0a26ab00bc6f43e58c; thanks Eric, Stu, and Mateo.

Loading...