None

stuhood got review request #4000!

[engine] Fix TargetMacro replacements of adapted aliases

Review Request #4000 — Created June 13, 2016 and submitted

stuhood
pants
3506, 3607
pants-reviews
gmalmquist, jsirois, kwlzn

In cases where a TargetMacro has been installed as wrapping an existing symbol, it will not exist in the target_aliases field, and will thus not be replaced with our adaptor.

"Why yes, this continues to highlight the importance of:"
https://github.com/pantsbuild/pants/issues/3560
https://github.com/pantsbuild/pants/issues/3561

https://travis-ci.org/pantsbuild/pants/builds/140649055
And tested on internal TargetMacro usecases.

KW
  1. Ship It!
  2. 
      
ST
ST
KW
  1. nice, lgtm!

  2. 
      
ST
ST
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as 7a63b453d713d392a78fe9ebf252e78ab692adbd

Loading...