Use the z.jar files on the zinc classpath instead of the destination directory of the class files.

Review Request #3982 - Created June 7, 2016 and submitted

Information
Garrett Malmquist
pants
gmalmquist/zundel-compile-with-zjars
3529, 3567
Reviewers
pants-reviews
benjyw, nhoward_tw, stuhood, zundel

Use the z.jar files on the zinc classpath instead of the destination directory of the class files.

This is zundel's patch from https://rbcommons.com/s/twitter/r/3955 with changes according to Stu's feedback. I made the changes since zundel is OOO.

CI went green: https://travis-ci.org/pantsbuild/pants/builds/135986552
CI went green: https://travis-ci.org/pantsbuild/pants/builds/136462391

Issues

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Garrett Malmquist
Stu Hood
Eric Ayers
Nick Howard (Twitter)
Nick Howard (Twitter)
Eric Ayers
Eric Ayers
Garrett Malmquist
Review request changed

Status: Closed (submitted)

Change Summary:

In 93894d4d59a5d80afb3dfc7be0a7d5a49d497b29.

Thanks Eric (for writing the original patch and reviewing my changes), and Benjy, Stu, Mateo, and Nick!

Loading...