[engine] Capture the `resources=globs` argument for Python targets

Review Request #3979 — Created June 7, 2016 and submitted

stuhood
pants
3506, 3566
pants-reviews
kwlzn, nhoward_tw

This fixes #3506, which is caused by our conversion of the globs/rglobs objects without capturing them later.

  • Capture the resources=globs argument for Python targets
  • Open tickets to design the migration path to typed Sources

http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/branch/PR-3566/2/

  1. lgtm, one comment.

  2. src/python/pants/engine/legacy/structs.py (Diff revision 1)
     
     
     
     

    any reason this bit couldn't be simplified to:

    if self.resources is None:
      return super(PythonTargetAdaptor, self).field_adaptors
    

    ?

  3. 
      
  1. 
      
  2. src/python/pants/engine/legacy/structs.py (Diff revision 1)
     
     
     
     
     
     
     

    Good point. Also, it looks like this is discarding the parent field_adaptors as is, which is no good. Need to find a better way to test it.

  3. 
      
  1. Ship It!
  2. 
      
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as 04e44579cff91d4c8b4f140d0b298b04fdc228c0

Loading...