Make checkstyle's options filename-agnostic.
Review Request #3975 — Created June 6, 2016 and submitted — Latest diff uploaded
|benjyw, patricklaw, stuhood, zundel|
See issue: https://github.com/pantsbuild/pants/issues/3555 We were getting excessive cache invalidation in our shared build cache for checkstyle, because it was fingerprinting the absolute paths to the configuration files. There's really no reason for checkstyle to care about the names of the files containing rules and suppressions, all it should care about are the file contents. This change enforces that.
Added integration tests exercising the caching behavior (unit tests don't work because FakeOptions are not fingerprinted).
CI went green here: https://travis-ci.org/pantsbuild/pants/builds/135664207
CI went green here: http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/branch/PR-3559/3/
CI went green here: https://travis-ci.org/gmalmquist/pants/builds/136502538