Make `JvmAppAdaptor` compatible with bare `bundle()` form.
Review Request #3965 - Created June 2, 2016 and submitted
|jsirois, peiyu, stuhood|
Given a BUILD file like:jvm_app( name='bundle', basename='xyz', binary='x/y/z:bin', bundles=[ bundle() ] )
./pants --enable-v2-engine list <target>currently throws an
AttributeError: JvmAppAdaptor(address=x/y:bundle) does not have attribute 'field_adaptors'. this was an in-property exception (itself causing an
AttributeErrorfor failed resolution of the property) which actually turned out to be a second
AttributeErrorfor an invalid access of an undefined
this review adds handling of this case with logging - as well as blanket exception logging for the
field_adaptorsproperties to help reveal otherwise hidden exceptions in the future.
reproduced locally in our monorepo against one of ~250 targets of this form. verified the exception logging prior to the change and the warning logging after the change.
Revision 2 (+73 -26)
Status: Closed (submitted)
thanks Stu & Peiyu! submitted @ cb1c39fe5836dc65db6b9bef14dc205ad18909d2