Please add a test case to cover this.
fix an issue introduced in go resolve refactoring
Review Request #3963 — Created June 1, 2016 and submitted
|benjyw, jsirois, stuhood|
Go Fetch task will fetch packages only for invalid versioned targets (VTs), but it will map_fetched_remote_source for all VTs.
My previous refactor moved the map_fetched_remote_source inside valid check of VT, which means only for invalid VT will map_fetched_remote_source be executed.
This caused test failure when testing our internal go projects. I think previously it passed the internal test because cache read/write was disabled in our internal pants.ini at that moment, thus VTs were always invalid.
This change moves map_fetched_remote_source logic outside of valid check of VT, so that it is executed for all VTs.
and test against some go code internally in Twitter.
|s/run/Run/ s/is resolved correctly/are resolved correctly./||BE benjyw|
Revision 2 (+7 -4)