expose products for jvm bundle create and python binary create tasks

Review Request #3959 - Created May 31, 2016 and discarded

Information
Yujie Chen
pants
3477, 3501
Reviewers
pants-reviews
mateor, patricklaw, peiyu, stuhood

bundle.jvm currently does not expose a product_type for any archives it creates (only the loose bundle directory). And binary.python-binary-create currently does not expose any products at all. We would like these tasks to expose products, in order to be able to consume those products in downstream (internal) tasks.

In particular, JVM apps (at least at Twitter) are generally published as archived (zip'd/tar'd) bundles. And python apps are deployed directly as pexes.
1. Expose deployable_archive product in jvm bundle_create task (arhives, including zip, tar, tar.gz, tar.bz2).
2. Expose same deployable_archive product in python_binary_create task (pexes).
3. Above products live in .pants.d, and they have symlinks created in dist dir.
4. Modify integration and unit test cases to accommodate changes in (3).
5. Add test cases.

ci pending:
https://travis-ci.org/pantsbuild/pants/builds/135075150

Issues

  • 4
  • 0
  • 0
  • 4
Description From Last Updated
Can we change the product name so that jvm and python do not share a product? We have an open ... Mateo Rodriguez Mateo Rodriguez
As with the change to the go code, this invalidation block should be as tiny as possible. The body of ... Stu Hood Stu Hood
This comment no longer applies so it should be amended or deleted. Mateo Rodriguez Mateo Rodriguez
I am finding the if statements on the archive to be confusing. There are checks for archiver, archivepath, app.archive and ... Mateo Rodriguez Mateo Rodriguez
Stu Hood
Stu Hood
Yujie Chen
Mateo Rodriguez
Yujie Chen
Stu Hood
Mateo Rodriguez
Yujie Chen
Review request changed

Status: Discarded

Loading...