Use the z.jar files on the zinc classpath if they exist

Review Request #3955 - Created May 30, 2016 and discarded

Information
Eric Ayers
pants
zundel/compile-with-zjars
3529
Reviewers
pants-reviews
benjyw, gmalmquist, nhoward_tw, stuhood

Added feature to use the z.jar files on the zinc classpath if they exist.

This decreases the compile time of our biggest target from 6m30s to 1m24s.

Ran this through our CI builder and tested locally. Dramatic compile time improvements all around.

CI is green at https://travis-ci.org/pantsbuild/pants/builds/134164353

Issues

  • 2
  • 7
  • 0
  • 9
Description From Last Updated
As mentioned in my comment to Benjy: we create these jars as we finish compiling each target, so there should ... Stu Hood Stu Hood
They always exist. The "previous compile" part isn't accurate, because the current compile creates them for upstream targets before compiling ... Stu Hood Stu Hood
Eric Ayers
Benjy Weinberger
Benjy Weinberger
Eric Ayers
Benjy Weinberger
Stu Hood
Stu Hood
Benjy Weinberger
Eric Ayers
Eric Ayers
Garrett Malmquist
Garrett Malmquist
Benjy Weinberger
Mateo Rodriguez
Stu Hood
Garrett Malmquist
Eric Ayers
Review request changed

Status: Discarded

Change Summary:

See https://rbcommons.com/s/twitter/r/3982/ which supercedes this patch

Loading...