Decode Watchman file event filenames to UTF-8.

Review Request #3951 — Created May 29, 2016 and submitted

3524, 3525
jsirois, peiyu, stuhood

watchman does not currently handle UTF-8 decoding (see in event payloads.

this is a quick change to add UTF-8 decoding of all filenames in the watchman change event handler to relieve an issue seen in #3524.

repro'd #3524 locally and added assertions to the integration test that failed prior to and succeeded after the change.

  1. Ship It!
  2. this could be brittle if the message changes later, better look for if there are error/warn or define a error string, something more stable

    1. good call, changed this to check for any warnings or errors in the log.

Review request changed

Status: Closed (submitted)

Change Summary:

thanks Peiyu! fast-tracking this in @ a2b1091a63e87a7b71ce78ce324ec5974b7ef3c8 to help relieve CI flakiness, but happy to follow-up with any issues that folks may have after the fact.