Update contributors.sh script not to count publish commits

Review Request #3946 — Created May 28, 2016 and submitted

zundel
pants
zundel/contributors.sh
00a16d3...
pants-reviews
benjyw, molsen, stuhood

Whenever you run ./pants publish.jar ... it can add multiple commits to the commit log of the form:

pants build committing publish data for push of org.pantsbuild#...

These aren't very useful for counting real contributions at the end of a release cycle, so let's exclude them from the count.

I didn't run CI because this script doesn't get executed as a part of CI

Before:

$ build-support/bin/contributors.sh -s HEAD~30
  13 Eric Ayers
   4 Kris Wilson
   3 Stu Hood
   3 Chris Pesto
   2 Yi Cheng
   2 Garrett Malmquist
   1 Wolfram Arnold
   1 Bruno Bieth
   1 Benjy Weinberger

After:

build-support/bin/contributors.sh -s HEAD~30
   6 Eric Ayers
   4 Kris Wilson
   3 Stu Hood
   3 Chris Pesto
   2 Garrett Malmquist
   1 Yi Cheng
   1 Wolfram Arnold
   1 Bruno Bieth
   1 Benjy Weinberger
  • 0
  • 0
  • 0
  • 1
  • 1
Description From Last Updated
  1. Ship It!
  2. 
      
  1. Ship It!
  2. build-support/bin/contributors.sh (Diff revision 1)
     
     

    Maybe add a comment in whichever script creates these commits that if this text changes there, to change it here too.

    1. Its not a script unless you are counting pants itself as a script :-) src/python/pants/task/scm_publish_mixin.py I'm not sure a comment there is appropriate.

  3. 
      
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks Stu & Benjy, commit 4546b3b

Loading...