[engine] clean up non in-memory storage usage, only needed for LocalMultiprocessEngine

Review Request #3940 - Created May 28, 2016 and submitted

Information
Peiyu Wang
pants
3510, 3514
Reviewers
pants-reviews
ity, kwlzn, patricklaw, stuhood

This review serves for two purposes:

  1. Use in_memory as default because lmdb is only useful for
    LocalMultiprocessEngine which is still experimental.
  2. We suspect #3510 is to do with lmdb not closing files and
    there are more lmdb tests over time. This won't address the root
    case, but will help us isolate issues. [1]

Also did some clean ups where scheduler should not depend on storage.

[1] In fact, it's likely to do with somethig else, with this change, still see travis hang
https://travis-ci.org/peiyuwang/pants/jobs/133499909

https://travis-ci.org/peiyuwang/pants/builds/133486889 passed

A later travis run hangs
https://travis-ci.org/peiyuwang/pants/jobs/133499909

Peiyu Wang
Kris Wilson
Peiyu Wang
Review request changed

Status: Closed (submitted)

Change Summary:

0f8752b9125f4f570c72cc9f244c05234efb270b

Stu Hood

Thanks!

Loading...