Robustify pantsd + watchman integration tests.

Review Request #3912 - Created May 20, 2016 and submitted

Information
Kris Wilson
pants
kwlzn/pantsd/3377
3377, 3393
Reviewers
pants-reviews
benjyw, jsirois, nhoward_tw, peiyu, stuhood

Fixes #3377.

  • Make failure to successfully launch watchman (when configured) a fatal event.
  • Add an option to override the watchman UNIX socket path to get around the 'path too long' issue with UNIX sockets.
  • Make ProcessManager's .pids dir relocatable - and isolate that in the integration tests.
  • More strictly check the daemon state between integration test runs.
  • Misc cleanups, tests.

CI is green @

  • https://travis-ci.org/pantsbuild/pants/builds/132437726
  • http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/branch/PR-3393/30

I submitted multiple CI-triggering commits last night to attempt to repro the initial issue. Other than what appear to be spurious failures in Jenkins, that seems to be successful - and is green-lit across 4+ Travis runs (including several not-accounted-for rebuilds).

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Kris Wilson
Stu Hood
Benjy Weinberger
Kris Wilson
Stu Hood
Yi Cheng
Kris Wilson
Review request changed

Status: Closed (submitted)

Change Summary:

thanks folks. submitted @ 1f554c8ca1fc56b4830091d7c75aac3056785e9e

Loading...