Adding product dependency for NodeResolve/NodeTest

Review Request #3906 — Created May 19, 2016 and submitted

cpesto
pants
chrispesto:node_test_product_dependency
3466
pants-reviews
jsirois, stuhood

Might also add a test for the NodeTest side once https://rbcommons.com/s/twitter/r/3870/ is in master and test_node_test.py is available from that diff.



CP
RO
  1. Ship It!
  2. 
      
CP
ST
  1. 
      
  2. Product types can be any object... if possible, leaving this as NodePaths would be preferable, as it nets you a declared class dependency and import rather than something that is stringly typed.

    1. Ok, switched back! The diff is smaller now.

  3. 
      
CP
ST
  1. Ship It!
  2. 
      
CP
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as 4c32204383a79ba1651d5cf702eff025b85b27a7

Loading...