Make pinger.py work with both HTTP and HTTPS.

Review Request #3904 - Created May 17, 2016 and submitted

Information
Garrett Malmquist
pants
gmalmquist/pinger-https
3463
Reviewers
pants-reviews
benjyw, patricklaw, stuhood, zundel

Our remote artifact cache serves over HTTPS, which the RESTful
artifact cache ostensibly supports, but the Pinger was previously
checking what URLs are reachable using only HTTP.

This change switches pinger to use requests instead of httplib,
which gives us HTTPS support "for-free".

Added test to pinger.py. All tests in pinger.py pass locally.

Jenkins went green: http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/branch/PR-3463/5/

Issues

  • 0
  • 3
  • 0
  • 3
Description From Last Updated
Benjy Weinberger
Eric Ayers
Garrett Malmquist
Garrett Malmquist
Benjy Weinberger
Garrett Malmquist
Eric Ayers
Garrett Malmquist
Review request changed

Status: Closed (submitted)

Change Summary:

In e662399b8c6810deee53f16556c7d5cc1cfe37c8, thanks Benjy & Eric!

Loading...