Only run tests once each...

Review Request #389 — Created May 21, 2014 and submitted

benjyw
pants
pants-reviews
jsirois, wickman
This was due to the regular target dep-following logic being duplicated
by legacy python_test_suite logic.

This change gets rid of python_test_suite (or rather, makes it
an alias of the 'dependencies' target, to not break existing BUILD files).

We're now back to taking ~2m20s to run all the pants tests.
Ran all the unit tests before and after. 

Rejoiced at the improved timings.

Temporarily added some code to count the number of times each test was run, to verify the premise.
LA
  1. 
      
  2. bonus points if you go into 
    src/python/pants/tasks/builddict.py , 
    and in the PREDEFS structure,
    add
    
    "python_test_suite": {"defn": msg_entry("python_test_suite",
                      """Deprecated way to group Python tests; use `dependencies`_""")},
  3. 
      
BE
LA
  1. Ship It!
  2. 
      
JS
  1. Thanks Benjy.
  2. 
      
BE
Review request changed

Status: Closed (submitted)

Loading...