Fix GoFetch and test.

Review Request #3888 — Created May 14, 2016 and submitted — Latest diff uploaded

jsirois
pants
jsirois/issues/3424/fix_fetch
3424, 3442
3889
7bd2e61...
pants-reviews
benjyw, kwlzn
The `GoFetch._find_meta_tag` function was broken in return type and the
`GoFetchTest` failed to arrange a correct 3rdparty source root.  Fix both.

 contrib/go/src/python/pants/contrib/go/tasks/go_fetch.py             | 15 ++++++++++++---
 contrib/go/tests/python/pants_test/contrib/go/tasks/test_go_fetch.py |  6 +++++-
 2 files changed, 17 insertions(+), 4 deletions(-)

Before this fix, on my machine, this failed 3 for 3:

./pants test \
  contrib/go/tests/python/pants_test/contrib/go/tasks/:go_fetch -- \
    -vktest_transitive_download_remote_libs_

Green after the fix.

CI went green here:
http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/branch/PR-3442/4/

Loading...