add a command line option for meta tag resolution

Review Request #3882 - Created May 12, 2016 and submitted

Information
Yujie Chen
pants
3434
Reviewers
pants-reviews
benjyw, jsirois, stuhood

The support for meta tag parsing is introduced here: https://github.com/pantsbuild/pants/commit/7a7f51390cacd82a3e982eaf4516c510f23092c0

As developers inside company network, we don't always want to talk to outside netwrok.

Thus add an option to turn this on and off.

The new option is skip-meta-tag-resolution, under scope: resolve.go. To use it in the command line, simply do "--resolve-go-skip-meta-tag-resolution". The default value is False, which means meta tag will be parsed and url in it will be used for redirection.

https://travis-ci.org/pantsbuild/pants/builds/130108832

Issues

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Yujie Chen
Yujie Chen
Benjy Weinberger
Yujie Chen
Benjy Weinberger
Yujie Chen
John Sirois
Yujie Chen
John Sirois
Yujie Chen
Yujie Chen
Yujie Chen
John Sirois
Yujie Chen
Review request changed

Status: Closed (submitted)

Change Summary:

Now on master:

git log -1 origin/master
commit e90f08fc6bca63cfeae95be25d75e6082fc73213
Author: Yujie Chen <yujieproject@gmail.com>
Date:   Fri May 13 22:44:39 2016 -0600

    add a command line option for meta tag resolution
    
    The support for meta tag parsing is introduced here: https://github.com/pantsbuild/pants/commit/7a7f51390cacd82a3e982eaf4516c510f23092c0
    
    As developers inside company network, we don't always want to talk to outside netwrok.
    
    Thus add an option to turn this on and off.
    
    The new option is skip-meta-tag-resolution, under scope: resolve.go. To use it in the command line, simply do **"--resolve-go-skip-meta-tag-resolution"**. The default value is False, which means meta tag will be parsed and url in it will be used for redirection.
    
    Testing Done:
    https://travis-ci.org/pantsbuild/pants/builds/130108832
    
    Bugs closed: 3434
    
    Reviewed at https://rbcommons.com/s/twitter/r/3882/
John Sirois
Patched in @ https://github.com/pantsbuild/pants/commit/e90f08fc6bca63cfeae95be25d75e6082fc73213 on master.
Please mark this review as submitted.
Loading...