Fix SourceRoots.all_roots to respect fixed roots.

Review Request #3881 — Created May 12, 2016 and submitted — Latest diff uploaded

jsirois
pants
jsirois/issues/3421
3421, 3425
3866
1c18882...
pants-reviews
benjyw, zundel
Previously a fixed root that prefix-matched a pattern would lose to the
pattern.

 src/python/pants/source/source_root.py             | 68 ++++++++++++++++++++++++++++++++++++--------------
 tests/python/pants_test/source/test_source_root.py | 23 +++++++++++------
 2 files changed, 64 insertions(+), 27 deletions(-)

Modified the existing test to fail then fixed. Green locally:

./pants test \
  tests/python/pants_test/source/:: \
  contrib/go/tests:: \
  contrib/go/examples:: -- -v

CI went green here:
http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/branch/PR-3425/6/

Loading...