Fix SourceRoots.all_roots to respect fixed roots.

Review Request #3881 - Created May 12, 2016 and submitted

Information
John Sirois
pants
jsirois/issues/3421
3421, 3425
3866
1c18882...
Reviewers
pants-reviews
benjyw, zundel
Previously a fixed root that prefix-matched a pattern would lose to the
pattern.

 src/python/pants/source/source_root.py             | 68 ++++++++++++++++++++++++++++++++++++--------------
 tests/python/pants_test/source/test_source_root.py | 23 +++++++++++------
 2 files changed, 64 insertions(+), 27 deletions(-)

Modified the existing test to fail then fixed. Green locally:

./pants test \
  tests/python/pants_test/source/:: \
  contrib/go/tests:: \
  contrib/go/examples:: -- -v

CI went green here:
http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/branch/PR-3425/6/

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
John Sirois
John Sirois
John Sirois
Benjy Weinberger
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Change Summary:

Now on master:

git log -1 origin/master
commit 650eed65d90af3de88df366dd216ea12b90ebecf
Author: John Sirois <john.sirois@gmail.com>
Date:   Thu May 12 16:25:01 2016 -0600

    Fix SourceRoots.all_roots to respect fixed roots.
    
    Previously a fixed root that prefix-matched a pattern would lose to the
    pattern.
    
    Testing Done:
    Modified the existing test to fail then fixed.  Green locally:
    ```
    ./pants test \
      tests/python/pants_test/source/:: \
      contrib/go/tests:: \
      contrib/go/examples:: -- -v
    ```
    
    CI went green here:
      http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/branch/PR-3425/6/
    
    Bugs closed: 3421, 3425
    
    Reviewed at https://rbcommons.com/s/twitter/r/3881/
Loading...