[engine] Use the appropriate `BaseGlobs` subclass for excludes

Review Request #3875 - Created May 12, 2016 and submitted

Information
Stu Hood
pants
3392, 3414
Reviewers
pants-reviews

During the bundle bump (https://rbcommons.com/s/twitter/r/3818/), I was confused by #3413, and broke the filemap tests. While trying to fix them for this review, I found #3413.

I don't have time to dive into #3413 right now, but this fixes _filespec_for_excludes to use the relevant BaseGlobs class if it exists.

  • Fix the tests, and highlight the fact that zglobs filespecs are broken.

https://travis-ci.org/pantsbuild/pants/builds/129582986
http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/branch/PR-3414/1/

Yujie Chen
Stu Hood
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as 131a7db46767858fa0761ae03ae4fe456de680a2

(unrelated CI failure)

Loading...