Making the permissions of the local artifact cache configurable.
Review Request #3869 - Created May 11, 2016 and submitted
|benjyw, patricklaw, stuhood, zundel|
We ran into some internal problems due to the permissions of files
created for the local artifact cache being 0600 instead of 0644.
This is mostly a subset of https://rbcommons.com/s/twitter/r/3867/.
Added passing tests to test_contextutil.py.
CI went green here: https://travis-ci.org/pantsbuild/pants/builds/129562253
Maybe the new parameter should be a named parameter so its optional? I know this isn't a public API so it isn't necessary.
add pydoc for new parameter? maybe just a pointer to the other class
Doesn't this constructor also need to be modified?
Why not use a file permission that is easier for us to delete or more commonly used (0644? 0622?)
So Square will be setting this in the pants.ini, to something like 644? We aren't as strict, perhaps we should be.
The permissions bit to the tempdirs seems like it could be useful in other places, but what is the use case for ever flipping the permissions of the artifact_cache as opposed to hardcoding?