PrepCommandIntegration handles parallel runs.

Review Request #3864 - Created May 11, 2016 and submitted

Information
John Sirois
pants
jsirois/issues/3383
3383, 3400
166b96c...
Reviewers
pants-reviews
mateor, zundel
The test now runs against ephemeral BUILD files uniquely generated for
each test method.

 testprojects/src/java/org/pantsbuild/testproject/prepcommand/BUILD  | 28 ---------------
 tests/python/pants_test/core_tasks/test_prep_command_integration.py | 93 ++++++++++++++++++++++++++++++--------------------
 2 files changed, 56 insertions(+), 65 deletions(-)

Locally green:
./pants test tests/python/pants_test/core_tasks:prep_command_integration

CI went green here:
http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/branch/PR-3400/2/

John Sirois
Eric Ayers
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Change Summary:

Now on master:

git log -1 origin/master
commit 0269c4d7426c72704bf038ec43353dd04e1a871a
Author: John Sirois <john.sirois@gmail.com>
Date:   Wed May 11 11:21:45 2016 -0600

    PrepCommandIntegration handles parallel runs.
    
    The test now runs against ephemeral BUILD files uniquely generated for
    each test method.
    
    Testing Done:
    Locally green:
    `./pants test tests/python/pants_test/core_tasks:prep_command_integration`
    
    CI went green here:
      http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/branch/PR-3400/2/
    
    Bugs closed: 3383, 3400
    
    Reviewed at https://rbcommons.com/s/twitter/r/3864/
Mateo Rodriguez

Thanks, John. It would proabably be generally useful to have a library that can return this kind of info about arbitrary run_pants calls. I know I went so far
as to grep the output in one of my early Android tests. I will open an issue to track it - maybe I will be able to dig up some time to see what I can do.

Loading...