Add FindBugs plugin to contrib

Review Request #3847 - Created May 9, 2016 and submitted

Information
Chris Heisterkamp
pants
findbugs-plugin
3370
Reviewers
pants-reviews
jsirois, stuhood, zundel
Add FindBugs plugin to contrib

Travis CI: https://travis-ci.org/pantsbuild/pants/builds/129933367

Add a plugin to run FindBugs http://findbugs.sourceforge.net/ code analysis on Java projects.

Example output from ./pants compile src/java::

20:13:38 00:09       [findbugs]
                   Bug[low]: DM_DEFAULT_ENCODING Found reliance on default encoding in org.pantsbuild.tools.junit.impl.AntJunitXmlReportListener.testRunFinished(Result): new java.io.FileWriter(File) At AntJunitXmlReportListener.java:[lines 43-593]
                   Bug[low]: NM_CLASS_NOT_EXCEPTION Class org.pantsbuild.tools.junit.impl.AntJunitXmlReportListener$Exception is not derived from an Exception, even though it is named as such At AntJunitXmlReportListener.java:[lines 57-78]
                   Bug[low]: DM_DEFAULT_ENCODING Found reliance on default encoding in org.pantsbuild.tools.junit.impl.ConsoleRunnerImpl.run(Iterable): new java.io.PrintStream(OutputStream) At ConsoleRunnerImpl.java:[lines 61-879]
                   Bug[low]: VA_FORMAT_STRING_USES_NEWLINE Format string should use %n rather than \n in org.pantsbuild.tools.junit.impl.ConsoleRunnerImpl.main(String[]) At ConsoleRunnerImpl.java:[lines 61-879]
                   Bug[low]: VA_FORMAT_STRING_USES_NEWLINE Format string should use %n rather than \n in org.pantsbuild.tools.junit.impl.ConsoleRunnerImpl.notFoundError(String, PrintStream, Throwable) At ConsoleRunnerImpl.java:[lines 61-879]
                   Bug[normal]: UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS Uncallable method org.pantsbuild.tools.junit.impl.ConsoleRunnerImpl$1Options.setNumRetries(int) defined in anonymous class At ConsoleRunnerImpl.java:[lines 643-734]
                   Bug[normal]: UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS Uncallable method org.pantsbuild.tools.junit.impl.ConsoleRunnerImpl$1Options.setParallelThreads(int) defined in anonymous class At ConsoleRunnerImpl.java:[lines 643-734]
                   Bug[normal]: UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS Uncallable method org.pantsbuild.tools.junit.impl.ConsoleRunnerImpl$1Options.setTestShard(String) defined in anonymous class At ConsoleRunnerImpl.java:[lines 643-734]
                   Bug[low]: VA_FORMAT_STRING_USES_NEWLINE Format string should use %n rather than \n in org.pantsbuild.tools.junit.impl.ConsoleRunnerImpl$1Options.setParallelThreads(int) At ConsoleRunnerImpl.java:[lines 643-734]
                   Bug[low]: DM_DEFAULT_ENCODING Found reliance on default encoding in org.pantsbuild.tools.junit.impl.ConsoleRunnerImpl$StreamCapturingListener.testFailure(Failure): new String(byte[]) At ConsoleRunnerImpl.java:[lines 210-323]
                   Bugs: 10 (High: 0, Normal: 3, Low: 7)

Issues

  • 0
  • 5
  • 0
  • 5
Description From Last Updated
Chris Heisterkamp
John Sirois
Stu Hood
Stu Hood
Chris Heisterkamp
Chris Heisterkamp
Chris Heisterkamp
Eric Ayers
Eric Ayers
Eric Ayers
Chris Heisterkamp
Review request changed

Status: Closed (submitted)

Loading...