Isolate Jenkins CI ivy caches.
Review Request #3829 - Created May 5, 2016 and submitted
| Information | |
|---|---|
| John Sirois | |
| pants | |
| jsirois/issues/3339/isolate_ivy_cache_dir | |
| 3339, 3342 | |
| 3679d5d... | |
| Reviewers | |
| pants-reviews | |
| kwlzn, mateor, patricklaw, zundel | |
Jenkinsfile | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)
CI went green here: http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/branch/PR-3342/4/
s/Jenins/Jenkins/ in the title.
Review request changed
Change Summary:
Fix missing " Jenkinsfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Summary: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
|||||||||
Commit: |
|
|||||||||
Diff: |
Revision 2 (+7 -6) |
Hrm, got this:
... ==================== FAILURES ==================== ___ ExportIntegrationTest.test_export_jar_path ___ self = <pants_test.backend.project_info.tasks.test_export_integration.ExportIntegrationTest testMethod=test_export_jar_path> def test_export_jar_path(self): with self.temporary_workdir() as workdir: test_target = 'examples/tests/java/org/pantsbuild/example/usethrift:usethrift' json_data = self.run_export(test_target, workdir, load_libs=True) with subsystem_instance(IvySubsystem) as ivy_subsystem: ivy_cache_dir = ivy_subsystem.get_options().cache_dir common_lang_lib_info = json_data.get('libraries').get('commons-lang:commons-lang:2.5') self.assertIsNotNone(common_lang_lib_info) self.assertEquals( common_lang_lib_info.get('default'), > os.path.join(ivy_cache_dir, 'commons-lang/commons-lang/jars/commons-lang-2.5.jar') ) E AssertionError: u'/mnt/xvdb/jenkins/workspace/pantsbuild/pants/PR-3342/.cache/ivy/commons-lang/c [truncated]... != u'/home/jenkins/.ivy2/pants/commons-lang/commons-lang/jars/commons-lang-2.5.jar' [truncated]... E - /mnt/xvdb/jenkins/workspace/pantsbuild/pants/PR-3342/.cache/ivy/commons-lang/commons-lang/jars/commons-lang-2.5.jar E + /home/jenkins/.ivy2/pants/commons-lang/commons-lang/jars/commons-lang-2.5.jar tests/python/pants_test/backend/project_info/tasks/test_export_integration.py:126: AssertionError 1 failed, 33 passed, 1 xfailed in 566.29 seconds ...I'll switch to a HOME relocation.
Review request changed
Change Summary:
Work around fake subsystem options in tests. The subsystem initialization utility used in tests uses fake options that do not respect env vars, leading to expectation failures. Since relocating HOME amounts to the same 3 relocations, this is an arguably cleaner path as well. Jenkinsfile | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
Testing Done: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
|||||||||
Diff: |
Revision 3 (+8 -4) |
Review request changed
Change Summary:
Work around fake subsystem options in tests. The subsystem initialization utility used in tests uses fake options that do not respect env vars, leading to expectation failures. Since relocating HOME amounts to the same 3 relocations, this is an arguably cleaner path as well. Jenkinsfile | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+7 -6) |
Review request changed
Testing Done: |
|
|---|
Review request changed
Status: Closed (submitted)
Change Summary:
Now on master:
git log -1 origin/master
commit 73a99728cccc2b21fd5d808c5d0bfb25ed63e0c1
Author: John Sirois <john.sirois@gmail.com>
Date: Thu May 5 20:13:53 2016 -0600
Isolate Jenkins CI ivy caches.
Testing Done:
CI went green here:
http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/branch/PR-3342/4/
Bugs closed: 3339, 3342
Reviewed at https://rbcommons.com/s/twitter/r/3829/