Handle values for list options that end with quotes

Review Request #3813 — Created May 3, 2016 and submitted

nhoward_tw
pants
3304, 3327
pants-reviews
benjyw, jsirois, molsen
The current implementation will raise an error if a list option provided using the extend syntax ends with a double quote. This adds code to handle that case.

Wrote regression tests in the unit test suite. Saw them fail. Made them pass. CI away in the PR (3327).

BE
  1. Ship It!
  2. 
      
MO
  1. Could you add some test cases around strings ending with to make sure we don't get hit pythons odd behavior with raw strings ending in \?

  2. 
      
NH
JS
  1. I'm bowing out of this review.
  2. 
      
BE
  1. Ship It!
  2. 
      
NH
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as https://github.com/pantsbuild/pants/commit/a5249eb8e670976a7e89b344e08616ee73ae250b
Loading...