Add transitive dep required by javac 8.

Review Request #3808 - Created May 2, 2016 and submitted

Information
John Sirois
pants
jsirois/jenkins/javac8_fix_deps
3321
27e1b28...
Reviewers
pants-reviews
patricklaw, stuhood
examples/src/java/org/pantsbuild/example/make_it_rain/BUILD | 1 +
 1 file changed, 1 insertion(+)

Before the fix:

JAVA_HOME=/usr/lib/jvm/java-8-openjdk \
  ./pants clean-all compile examples/src/java/org/pantsbuild/example/make_it_rain
...
                   [3/3] Compiling 1 zinc source in 1 target (examples/src/java/org/pantsbuild/example/make_it_rain:make_it_rain).
15:26:03 00:04       [compile]

15:26:03 00:04         [zinc]
                       [info] Compiling 1 Java source to /home/jsirois/dev/pantsbuild/jsirois-pants/.pants.d/compile/zinc/252d64521cf9/examples.src.java.org.pantsbuild.example.make_it_rain.make_it_rain/current/classes...
                       [warn] bootstrap class path not set in conjunction with -source 1.6
                       [error] /home/jsirois/dev/pantsbuild/jsirois-pants/examples/src/java/org/pantsbuild/example/make_it_rain/MakeItRain.java:14: cannot access org.apache.thrift.TBase
                       [error]   class file for org.apache.thrift.TBase not found
                       [error]     Distance notMuch = new Distance().setNumber(8).setUnit("mm");
                       [error] Compile failed at May 2, 2016 3:26:03 PM [0.024s]

                   compile(examples/src/java/org/pantsbuild/example/make_it_rain:make_it_rain) failed: Zinc compile failed.
FAILURE: Compilation failure: Failed jobs: compile(examples/src/java/org/pantsbuild/example/make_it_rain:make_it_rain)


15:26:03 00:04   [complete]
               FAILURE

Now green.

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/127344136

Stu Hood
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Change Summary:

Now on master:

git log -1 origin/master
commit 477618c7969f421c55112ed6ab1691a66656de1e
Author: John Sirois <john.sirois@gmail.com>
Date:   Mon May 2 17:12:22 2016 -0600

    Add transitive dep required by javac 8.
    
    Testing Done:
    Before the fix:
    ```
    JAVA_HOME=/usr/lib/jvm/java-8-openjdk \
      ./pants clean-all compile examples/src/java/org/pantsbuild/example/make_it_rain
    ...
                       [3/3] Compiling 1 zinc source in 1 target (examples/src/java/org/pantsbuild/example/make_it_rain:make_it_rain).
    15:26:03 00:04       [compile]
    
    15:26:03 00:04         [zinc]
                           [info] Compiling 1 Java source to /home/jsirois/dev/pantsbuild/jsirois-pants/.pants.d/compile/zinc/252d64521cf9/examples.src.java.org.pantsbuild.example.make_it_rain.make_it_rain/current/classes...
                           [warn] bootstrap class path not set in conjunction with -source 1.6
                           [error] /home/jsirois/dev/pantsbuild/jsirois-pants/examples/src/java/org/pantsbuild/example/make_it_rain/MakeItRain.java:14: cannot access org.apache.thrift.TBase
                           [error]   class file for org.apache.thrift.TBase not found
                           [error]     Distance notMuch = new Distance().setNumber(8).setUnit("mm");
                           [error] Compile failed at May 2, 2016 3:26:03 PM [0.024s]
    
                       compile(examples/src/java/org/pantsbuild/example/make_it_rain:make_it_rain) failed: Zinc compile failed.
    FAILURE: Compilation failure: Failed jobs: compile(examples/src/java/org/pantsbuild/example/make_it_rain:make_it_rain)
    
    15:26:03 00:04   [complete]
                   FAILURE
    ```
    
    Now green.
    
    CI went green here:
      https://travis-ci.org/pantsbuild/pants/builds/127344136
    
    Bugs closed: 3321
    
    Reviewed at https://rbcommons.com/s/twitter/r/3808/
Loading...