Fixup `PEP8Error` to carry lines.

Review Request #3806 — Created May 2, 2016 and submitted

jsirois
pants
jsirois/python_checkstyle/fix_noqa
3319
3647
b34740b...
pants-reviews
molsen, nhoward_tw
This plumbing was missed in https://rbcommons.com/s/twitter/r/3647 and
it is needed to enable the higher-level `# noqa` support provided by
`checker.py`.

 contrib/python/src/python/pants/contrib/python/checks/tasks/checkstyle/pep8.py                    |  3 ++-
 contrib/python/tests/python/pants_test/contrib/python/checks/tasks/checkstyle/plugin_test_base.py |  8 +++++---
 contrib/python/tests/python/pants_test/contrib/python/checks/tasks/checkstyle/test_pep8.py        | 11 +++++++++++
 3 files changed, 18 insertions(+), 4 deletions(-)

Noticed this attempting to upgrade Aurora to pants 1.0.0.

New test was red prior to fix, green after. With this fix, Aurora
now passes python style checks again w/o altering its # noqas.

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/127130766

JS
ZU
  1. Thank you, we noticed this in our build in one place but we ended up just changing the code to work around it. Sorry I didn't raise an issue for it at the time.

  2. 
      
NH
  1. Ship It!
  2. 
      
JS
Review request changed

Status: Closed (submitted)

Change Summary:

Now on master:

git log -1 origin/master
commit c7e2d815119caad792357112bb89f1c3011679b1
Author: John Sirois <john.sirois@gmail.com>
Date:   Mon May 2 12:43:17 2016 -0600

    Fixup `PEP8Error` to carry lines.
    
    This plumbing was missed in https://rbcommons.com/s/twitter/r/3647 and
    it is needed to enable the higher-level `# noqa` support provided by
    `checker.py`.
    
    Testing Done:
    Noticed this attempting to upgrade Aurora to pants 1.0.0.
    
    New test was red prior to fix, green after.  With this fix, Aurora
    now passes python style checks again w/o altering its `# noqa`s.
    
    CI went green here:
      https://travis-ci.org/pantsbuild/pants/builds/127130766
    
    Bugs closed: 3319
    
    Reviewed at https://rbcommons.com/s/twitter/r/3806/
Loading...