Use NailgunTask's Java distribution consistently.

Review Request #3793 - Created April 30, 2016 and submitted

Information
Benjy Weinberger
pants
Reviewers
pants-reviews
jsirois, nhoward_tw, stuhood

A few NailgunTasks need the JDK's tools.jar, and were fetching
its path by going to DistributionLocator, instead of using
the distribution it will later execute with.

In practice, today, these likely end up being the same distribution.
But in the future, if a particular task restricts its choice of
distribution then we could end up running in one JDK with the
tools.jar of another JDK on our classpath. This change prevents
that from happening.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/126825440

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
John Sirois
Stu Hood
Benjy Weinberger
Review request changed

Status: Closed (submitted)

Change Summary:

e415a5ad6c7b84eee989e719eeab981c632c8017

Benjy Weinberger

Submitted. Thanks!

Loading...