Scrooge gen: Cache resolved scrooge deps
Review Request #3790 - Created April 29, 2016 and submitted
|Nick Howard (Twitter)|
|benjyw, jsirois, molsen, patricklaw|
The current behavior is that we re-resolve the scrooge dependencies for each thrift target. This changes scrooge gen so that only the first target created does a resolve and afterwards it is cached.
CI away on PR. Local testing against code gen targets.
language = self._thrift_defaults.language(target)
resolved_dep = self._resolved_dep_info()
is easier for my brain to diff the two lines in the if, still unfortunate that structs and service are the same number of chars and both start with s.
I find the any() equiv of this easier to mentally parse. Others may disagree.
Revision 2 (+19 -8)